Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(a11y): make menu traversable only when it is open #1491

Merged
merged 4 commits into from
Dec 26, 2022

Conversation

7nohe
Copy link
Contributor

@7nohe 7nohe commented Oct 15, 2022

Replaces #1448 and fixes #1332

  • disable tab key navigation in menu when menu is not shown
  • trap focus when menu is shown

@brc-dd brc-dd changed the title fix(theme): Make the menu traversable only when the menu is visible perf(a11y): make menu traversable only when it is open Dec 26, 2022
@brc-dd brc-dd merged commit 257f9e6 into vuejs:main Dec 26, 2022
@7nohe 7nohe deleted the fix/menu branch December 26, 2022 08:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

menu (navigation drawer) should not be traversable with keyboard when not shown
2 participants